Geoffrey Young wrote: [...]
modperl_apache_compat.c does exactly that. make sure to mark when it was added so when we bump up the minimal required version we can remove the old workarounds.
ap_table_compress first appears in 2.0.47. both 2.0.46 and 2.0.47 claim to have APR 0.9.4, so I guess we can't use that as a marker.
how about another function similar modperl_apr_func_not_implemented - the wording in that function is APR specific, but in this case APR version isn't sufficient (nor will it be when APR released don't follow httpd releases).
so, we probably need modperl_httpd_func_not_implemented, which would throw "() requires httpd version " #ver " or higher". even though it's an apr_ function and not an ap_ function, I think the meaning to the user is more clear.
Well, it's probably a useless thing for mod_perl anyways, since hardly any of the users know anything about apr, and even less about the version that they have. So the error would be much more useful if it'd say the required httpd version. On the other hand some of the apis can be used outside of mod_perl/httpd, so the apr version will be needed.
I'd suggest to change the argument to modperl_apr_func_not_implemented to be the httpd version and the apr version, so we can have:
#define modperl_apr_func_not_implemented(func, httpd_ver, apr_ver) \
{ \
dTHX; \
Perl_croak(aTHX_ #func "() requires httpd/" #httpd_ver "and apr/" #ver "or higher"); \
}
Later we can make it more elaborate to print the httpd requirement if we know that we run under httpd, otherwise print only the apr requirement. Feel free to implement it now ;)
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
