I'd suggest to change the argument to modperl_apr_func_not_implemented to be the httpd version and the apr version, so we can have:
#define modperl_apr_func_not_implemented(func, httpd_ver, apr_ver) \ { \ dTHX; \ Perl_croak(aTHX_ #func "() requires httpd/" #httpd_ver "and apr/"
#ver "or higher"); \ }
ok, here is an updated patch. when running under 2.0.46 you get this message for APR::Table::compress()
compress() requires httpd/2.0.47 and apr/0.9.4 or higher at /src/mod_perl-2.0/t/response/TestAPR/table.pm line 126.
the compress() specific tests are configured to not run (that was only a test :)
with 2.0.47 and 2.1 everything seems to work as expected.
+1, with a tiny extra correction below
[...]Index: src/modules/perl/modperl_apache_compat.c ===================================================================
we should probably use the full function name (I know I added the incomplete one before ;), but since you are fixing it already ...
apr_status_t apr_socket_timeout_get(apr_socket_t *sock, apr_interval_time_t *t)
{
- modperl_apr_func_not_implemented(timeout_get, 0.9.0);
+ modperl_apr_func_not_implemented(timeout_get, 2.0.40, 0.9.0);
return APR_ENOTIMPL;
}
+ modperl_apr_func_not_implemented(apr_socket_timeout_get, 2.0.40, 0.9.0);
apr_status_t apr_socket_timeout_set(apr_socket_t *sock, apr_interval_time_t t)
{
- modperl_apr_func_not_implemented(timeout_set, 0.9.0);
+ modperl_apr_func_not_implemented(timeout_set, 2.0.40, 0.9.0);
return APR_ENOTIMPL;
}
+ modperl_apr_func_not_implemented(apr_socket_timeout_set, 2.0.40, 0.9.0);
+/* added in APACHE_2_0_47/APR_0_9_4 */
+void apr_table_compress(apr_table_t *t, unsigned flags)
+{
+ modperl_apr_func_not_implemented(compress, 2.0.47, 0.9.4);
+}
+ modperl_apr_func_not_implemented(apr_table_compress, 2.0.47, 0.9.4);
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
