Joe Schaefer wrote:
Keep in mind this only fixes each(), values() remains fundamentally broken for multivalued keys (the MAGIC_KEYS code in apreq2 circumvents this problem, btw).
I'm sure it won't take too long before we will see another patch from the productive Joe-machine house :)
:-) Not for this in mp2. Technically the problem lies with Perl_sv_setsv_flags, which does not copy magic (except for vstrings in 5.8.1+, which explains the current apreq2 code). Once I better understand the purpose of the (currently undocumented?) mg_copy slot in struct mgvtbl, I'll see if I can convince p5p to let Perl_sv_setsv_flags copy magic whenever that slot is occupied.
That may just work, if it doesn't incur a significant delay for the generic case.
True, but it's MUCH quicker to run the standalone apr-ext tests while developing: eg. % t/TEST -no-httpd apr-ext # avoids ~30sec httpd startup delay
Shouldn't be the case with the latest Apache::Test, prefork should take just a few secs to start. But once we handle that apr-ext/apr one source two tests solution, you should be able to do either of the two.
Not using prefork (I haven't abandoned all hope for mp2+worker yet).
Yes, but for the majority of things it's faster to test with prefork, that why I use it most of the time, swithing to worker very infrequently just to check that things are still OK.
As mentioned before, I'd love to see apr-ext/ and non-apr-ext somehow re-using the same tests, instead of duplicating and spreading them all over, making it hard to maintain.
If it's too much of a bother, I can do that move.
Why not just copy them there instead of moving them? I don't see the harm in having some redundancy in the test suite.
That's not a redundancy, that's a duplication. If later on you change
something in one of the tests you need to do it in two places.
Yes, but it's not like the test suite will be silent about it, so it'd be hard to overlook the problem for very long.
that's not what I meant. I meant that it's easy to get those two locations out of sync, while both will keep working fine.
but we are on the same line here...
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
