Joe Schaefer wrote: [...]
In which case we first need to find out how to clearly indicate to a
user that values() are broken.
values() has *never, ever* worked for multivalued keys. This is a bugfix for values(), and it requires 5.8.0 or better.
The remainder of the patch fixes each() (which again, has *never, ever* worked for multivalued keys) so it returns the current value in list context(). The each() bugfix applies to
both 5.6.x and 5.8.x.
I understand all that, Joe. The problem I'm having with is the situation when someone writes code with perl 5.8.x which works fine, releases it on CPAN and then a user using 5.6.x will have obscure failures.
Beyond this, I have no idea what you are asking for.
So what I'm asking for is how can we make the code croak in that situation and not silently get broken.
It's great that you've fixed it for 5.8.x, but it's still broken for 5.6.x, I hope you understand what is the problem with that.
We don't want obscure bug reports from 5.6 users. Can we arrange for values() to croak, explaining that it won't work
That would be silly IMO, since values() works fine for tables which are not multivalued. It's only the multivalued case
which is broken.
right, so can we croak only for the multivalued case on 5.6.x?
and requires 5.8.1 (or is it 5.8.0)?
^^^^^
5.8.0 - please do not confuse this with the MAGIC KEYS experiment going on in apreq2.
got it. thanks.
And of course this needs to be documented.Good luck with that.
Thanks Joe. You know that writing docs is the passion of my life.
I'm just a lowly user trying to fix
a bug in mp2 that was reported here, on modperl-dev@ a very
long time ago. I've done my best to provide additional tests and documentation to accompany the patch. If need be I will
gladly submit another patch that includes the missing
ifdefs for 5.6, but much beyond that I'm not willing to go.
Sure, I'll add the missing one liner that the multivalues each is not working for 5.6.x.
And yes, another patch with ifdefs for 5.6 is much appreciated.
Thanks Joe.
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
