Stas Bekman <[EMAIL PROTECTED]> writes:
What about the 5.8.1 requirement? mp2 requires 5.6.1, will it work
there?
No, the mg_copy slot in MGVTBL wasn't added until 5.8.0, so it
will not work (probably won't compile?) for 5.6.x. Unfortunately
I didn't notice the 5.6.x issue until after I submitted the patch,
however the fix for that is very simple, so I'd prefer to wait until the patch is added before adding the 2-3 neded #ifdef 's to modperl_common_util.c.
If it's knowingly doesn't work with 5.6 it shouldn't be committed then until it's resolved. We try hard to keep cvs HEAD buildable at all times.
I'm waiting for Randy's refactoring of apr table tests to be committed and then integrate your patch. But first we need to resolve the 5.6.x issue.
The downside is that this means values() won't work right for 5.6, but there's only so much we can do about that. The each() fix will still apply to 5.6, since it requires no extra magic at all.
In which case we first need to find out how to clearly indicate to a user that values() are broken. We don't want obscure bug reports from 5.6 users. Can we arrange for values() to croak, explaining that it won't work and requires 5.8.1 (or is it 5.8.0)? And of course this needs to be documented.
Thanks.
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
