Stas Bekman wrote: > Geoffrey Young wrote: > >>>> stas, perrin had also mentioned the idea that since we were moving from >>>> Apache::OK to Apache2::OK (again with a virtual namespace) it might >>>> make >>>> more sense to use Apache::Const::OK instead. I guess that's lots of >>>> typing, >>>> but uses always have OK if they want. >>>> >>>> thoughts? >>> >>> >>> >>> Sure, go for it. >> >> >> >> and the same for APR::Const? APR::EBUSY would become APR::Const::EBUSY? > > > Obviously :)
:) ok, I did both of these. really, I have no idea how the Apache2::Const rename was working before I changed ConstantTable.pm and ModPerl::Code, but it was, despite the autogenerated modperl_constants.c having all the wrong computed class lengths... so, on that note, if a few other people could take a look at the changes it would be really appreciated, just to make sure I got it right. here are the important files: lib/ModPerl/Code.pm xs/tables/current/Apache2/ConstantsTable.pm lib/Apache2/ParseSource.pm all tests pass for me, but I guess that's no guarantee since they passed on my first attempt as well... --Geoff --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
