Philippe M. Chiasson wrote:
Stas Bekman wrote:

[EMAIL PROTECTED] wrote:


Author: gozer
Date: Fri Dec 16 13:20:23 2005
New Revision: 357236

URL: http://svn.apache.org/viewcvs?rev=357236&view=rev
Log:
"local %ENV;" caused Segmentation fault in modperl_env_request_tie()

Reported-By:  Peter Walsham <[EMAIL PROTECTED]>
Thread: http://thread.gmane.org/gmane.comp.apache.mod-perl/22236

a bug fix w/o adding a test?


Well, the test would cause a segfault, so figured it wasn't such a good idea
to add it.

I'm not following you Philippe, you've fixed it. Isn't that how all tests are written? You first write a test, you then fix it and then you commit the test and the fix, no?

But now that the fix is in, I guess I could make a test case to make
sure it now works. Good point Stas ;-)

Expect test case soon.

gozer++

Which reminds me, it would be nice to have a bug/ test categorie for such gems
that don't fit very nicely anywhere else.

This test fits perfectly into the main test suite. But yes, we need to have a new directory for other tests. Long ago I've suggested t_extra.

--
_____________________________________________________________
Stas Bekman mailto:[EMAIL PROTECTED]  http://stason.org/
MailChannels: Assured Messaging(TM) http://mailchannels.com/
The "Practical mod_perl" book       http://modperlbook.org/
http://perl.apache.org/ http://perl.org/ http://logilune.com/


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to