Stas Bekman wrote: > Philippe M. Chiasson wrote: >> Stas Bekman wrote: >>> [EMAIL PROTECTED] wrote: >>>> Author: gozer >>>> Date: Fri Dec 16 13:20:23 2005 >>>> New Revision: 357236 >>>> >>>> URL: http://svn.apache.org/viewcvs?rev=357236&view=rev >>>> Log: >>>> "local %ENV;" caused Segmentation fault in modperl_env_request_tie() >>>> >>>> Reported-By: Peter Walsham <[EMAIL PROTECTED]> >>>> Thread: http://thread.gmane.org/gmane.comp.apache.mod-perl/22236 >>> >>> a bug fix w/o adding a test? >> >> Well, the test would cause a segfault, so figured it wasn't such a >> good idea >> to add it. > > I'm not following you Philippe, you've fixed it. Isn't that how all > tests are written? You first write a test, you then fix it and then you > commit the test and the fix, no?
Yup, you are correct. This reasoning was caused by : gozer.brain->off(); >> But now that the fix is in, I guess I could make a test case to make >> sure it now works. Good point Stas ;-) >> >> Expect test case soon. > > gozer++ > >> Which reminds me, it would be nice to have a bug/ test categorie for >> such gems >> that don't fit very nicely anywhere else. > > This test fits perfectly into the main test suite. But yes, we need to > have a new directory for other tests. Long ago I've suggested t_extra. Wasn't t_extra for the kind of developer's tests what would not be executed unless we were building in maintainer-mode ? I was more thinking of a category of tests specifically to nail down known bugs. -------------------------------------------------------------------------------- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
signature.asc
Description: OpenPGP digital signature
