On Fri, 5 Nov 2021 at 09:25, Rainer Jung <rainer.j...@kippdata.de> wrote:

> Am 05.11.2021 um 10:07 schrieb Steve Hay:
> > On Fri, 5 Nov 2021 at 01:54, Edward J. Sabol <edwardjsa...@gmail.com
> > <mailto:edwardjsa...@gmail.com>> wrote:
> >
> >     Anyway, these are pretty minor changes, but I don't think this
> >     change is quite correct:
> >
> >     +    # No need to search PATH components
> >     +    # if $program already contains a path
> >     +    return $program if !OSX and !WINFU and
> >     +        $program =~ /\// and -f $program and -x $program;
> >     +
> >
> >     OSX uses slashes for path separators and supports "-f" and "-x". I
> >     feel the "!OSX and " should be removed here, but I can't test it as
> >     all of my Apache httpd systems are on Linux.
> >
> >          return $program if !WINFU and
> >              $program =~ /\// and -f $program and -x $program;
> >
> >
> > Unfortunately I can't test OSX either. Is anyone here able to?
> >
> > The change in question is this:
> >
> > https://svn.apache.org/viewvc?view=revision&revision=1880585
> > <https://svn.apache.org/viewvc?view=revision&revision=1880585>
> >
> > Rainer, did you include that "!OSX" for a specific reason? Do you know
> > if Ed is correct that it can be dropped as he suggests?
>
> I can't test OSX either and I think that was the only reason for the !OSX.
>
>

Ok, thanks.

I will wait a few more days in case anyone is able to test on OSX, but if
not then I will go ahead and release this as-is, i.e. with the !OSX since
it makes sense to retain it if nobody can test on that platform.

Reply via email to