Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/12#discussion_r17437258
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -462,6 +477,71 @@ public MutationState createTable(CreateTableStatement
statement, byte[][] splits
return connection.getQueryServices().updateData(plan);
}
+ public long updateStatistics(UpdateStatisticsStatement
updateStatisticsStmt) throws SQLException {
+ String tableName =
updateStatisticsStmt.getTable().getName().getTableName();
+ // Check before updating the stats if we have reached the
configured time to reupdate the stats once again
+ long minTimeForStatsUpdate =
connection.getQueryServices().getProps()
+ .getLong(StatisticsConstants.MIN_STATS_FREQ_UPDATION,
StatisticsConstants.DEFAULT_STATS_FREQ_UPDATION);
+ // TODO : Check if we need the table key type of table name here.
+ // May be we can avoid multiple calls from the
+ // same connection
+ byte[] tenantIdBytes = QueryConstants.EMPTY_BYTE_ARRAY;
+ // TODO : If tenantId is not null we may have to get the actual
table name (PTable.getPhysicalName)
--- End diff --
My thinking was to set the last_updated_date to the current time on the
server side. Then here we can check (using the select query I mentioned) what
the duration was and compare it against whatever the min duration is. It's
better to use DATE as the type so that external sql clients can interpret the
value. We'll likely query the stats table for our monitoring UI and
interpreting a long is not something the client should need to worry about.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
