Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/12#discussion_r17442126
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -117,121 +125,59 @@ public boolean apply(HRegionLocation location) {
}
protected List<KeyRange> genKeyRanges(List<HRegionLocation> regions) {
- if (regions.isEmpty()) {
- return Collections.emptyList();
+ if (regions.isEmpty()) { return Collections.emptyList(); }
+ List<PColumnFamily> columnFamilies =
this.tableRef.getTable().getColumnFamilies();
--- End diff --
True, good point. I think the basic logic will be:
if (table.getColumnFamilies().isEmpty() ||
scan.getFamilyMap().isEmpty()) {
guideposts = table.getGuidePosts();
} else {
byte[] defaultCF = SchemaUtil.getEmptyColumnFamily(table);
if (scan.getFamilyMap().contains(defaultCF)) { // Favor using
default CF if it's used in scan
guidePosts = table.getColumnFamily(defaultCF).getGuidePosts();
} else { // Otherwise, just use first CF in use by scan
guidePosts =
table.getColumnFamily(scan.getFamilyMap().keySet().iterator().next()).getGuidePosts();
}
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
