Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/12#discussion_r17439695
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -462,6 +477,71 @@ public MutationState createTable(CreateTableStatement
statement, byte[][] splits
return connection.getQueryServices().updateData(plan);
}
+ public long updateStatistics(UpdateStatisticsStatement
updateStatisticsStmt) throws SQLException {
+ String tableName =
updateStatisticsStmt.getTable().getName().getTableName();
+ // Check before updating the stats if we have reached the
configured time to reupdate the stats once again
+ long minTimeForStatsUpdate =
connection.getQueryServices().getProps()
+ .getLong(StatisticsConstants.MIN_STATS_FREQ_UPDATION,
StatisticsConstants.DEFAULT_STATS_FREQ_UPDATION);
+ // TODO : Check if we need the table key type of table name here.
+ // May be we can avoid multiple calls from the
+ // same connection
+ byte[] tenantIdBytes = QueryConstants.EMPTY_BYTE_ARRAY;
+ // TODO : If tenantId is not null we may have to get the actual
table name (PTable.getPhysicalName)
--- End diff --
Instead of passing in tenantId to ConnectionQueryServices.updateStats(),
let's pass in a KeyRange. Then the updateStats() can just set the scan
start/stop using the KeyRange.getLowerRange() and KeyRange.getUpperRange(). To
get the KeyRange, do this:
Actually, we should just do this now. Here's the code to figure out the
start/stop key based on the tenantId:
KeyRange analyzeRange = KeyRange.EVERYTHING_RANGE;
if (tenantId != null) {
assert(table.getSaltBuckets() == null); // Stats table
should not be salted
List<List<KeyRange>> tenantIdKeyRanges =
Collections.singletonList(Collections.singletonList(KeyRange.getKeyRange(tenantId)));
byte[] lowerRange =
ScanUtil.getMinKey(table.getRowKeySchema(), tenantIdKeyRanges,
ScanUtil.SINGLE_COLUMN_SLOT_SPAN);
byte[] upperRange =
ScanUtil.getMaxKey(table.getRowKeySchema(), tenantIdKeyRanges,
ScanUtil.SINGLE_COLUMN_SLOT_SPAN);
analyzeRange = KeyRange.getKeyRange(lowerRange,
upperRange);
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
