[
https://issues.apache.org/jira/browse/PHOENIX-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136729#comment-14136729
]
ASF GitHub Bot commented on PHOENIX-1198:
-----------------------------------------
Github user elilevine commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/15#discussion_r17644459
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/LogUtil.java
---
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.util;
+
+import java.util.Map;
+
+public class LogUtil {
--- End diff --
Tracing-only changes are in PR #13. This PR was supposed to be only for
logging-related code but I screwed it up because I pulled in my tracing changes
used in #13 because for logging I am using the same way to pass annotations in.
Tried to make that clear in this PR's description but clearly failed. Sorry
about that. Maybe take a look at #13 that has tracing-only changes?
> Add ability to pass custom tags to be added to log lines
> --------------------------------------------------------
>
> Key: PHOENIX-1198
> URL: https://issues.apache.org/jira/browse/PHOENIX-1198
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Eli Levine
> Assignee: Eli Levine
> Fix For: 5.0.0, 4.1
>
>
> These tags can be passed in either when creating connections or calling
> upsert/select. Similar to PHOENIX-1196. Maybe they can shared the same
> mechanism for passing in values to be logged/traced.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
