[
https://issues.apache.org/jira/browse/PHOENIX-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136471#comment-14136471
]
ASF GitHub Bot commented on PHOENIX-1198:
-----------------------------------------
Github user jyates commented on the pull request:
https://github.com/apache/phoenix/pull/15#issuecomment-55827917
This would be a lot nicer if you didn't mix the logging changes with the
tracing changes - the changelist would be much more succinct and to the point.
Otherwise, seems like the right approach, though it could use some cleanup
(docs, readability, etc)
> Add ability to pass custom tags to be added to log lines
> --------------------------------------------------------
>
> Key: PHOENIX-1198
> URL: https://issues.apache.org/jira/browse/PHOENIX-1198
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Eli Levine
> Assignee: Eli Levine
> Fix For: 5.0.0, 4.1
>
>
> These tags can be passed in either when creating connections or calling
> upsert/select. Similar to PHOENIX-1196. Maybe they can shared the same
> mechanism for passing in values to be logged/traced.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
