[
https://issues.apache.org/jira/browse/PHOENIX-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136462#comment-14136462
]
ASF GitHub Bot commented on PHOENIX-1198:
-----------------------------------------
Github user jyates commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/15#discussion_r17636489
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/trace/util/Tracing.java ---
@@ -43,6 +47,8 @@
import org.cloudera.htrace.wrappers.TraceRunnable;
import com.google.common.base.Function;
+import com.google.common.base.Preconditions;
+import com.sun.istack.NotNull;
--- End diff --
i think if you mark something as not null, you don't need to do the null
check - kind of the deal with programming by contract, ya?
> Add ability to pass custom tags to be added to log lines
> --------------------------------------------------------
>
> Key: PHOENIX-1198
> URL: https://issues.apache.org/jira/browse/PHOENIX-1198
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Eli Levine
> Assignee: Eli Levine
> Fix For: 5.0.0, 4.1
>
>
> These tags can be passed in either when creating connections or calling
> upsert/select. Similar to PHOENIX-1196. Maybe they can shared the same
> mechanism for passing in values to be logged/traced.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
