[
https://issues.apache.org/jira/browse/PHOENIX-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177102#comment-14177102
]
James Taylor commented on PHOENIX-944:
--------------------------------------
Thanks for the patch, [~maryannxue]. Here's some feedback:
- ClientGroupedAggregatingResultIterator looks similar to
GroupedAggregatingResultIterator, except it's doing some post processing on the
Tuple. Can you nest your ClientGroupedAggregatingResultIterator around
GroupedAggregatingResultIterator and do just the post processing part there?
Also, what exactly is the post processing you're doing - a code comment would
be good.
- Same with ClientUngroupedAggregatingResultIterator versus
UngroupedAggregatingResultIterator.
- What does the ClientScanPlan do?
- ClientAggregatePlan looks very similar to AggregatePlan. Would it be possible
to pass through what we need to AggregatePlan and/or create a subclass of it so
there's not so much duplication?
> Support derived tables in FROM clause that needs extra steps of client-side
> aggregation or other processing
> -----------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-944
> URL: https://issues.apache.org/jira/browse/PHOENIX-944
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 3.0.0, 4.0.0, 5.0.0
> Reporter: Maryann Xue
> Assignee: Maryann Xue
> Fix For: 3.0.0, 4.0.0, 5.0.0
>
> Attachments: 944.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Groupby in both outer and inner queries cannot be flattened. We can apply an
> extra step of client-side aggregation to handle such cases.
> See DerivedTableIT.java for all those examples that are currently not
> supported.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
