[
https://issues.apache.org/jira/browse/PHOENIX-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178726#comment-14178726
]
Maryann Xue commented on PHOENIX-944:
-------------------------------------
bq. if you have a common base class with the existing logic for
GroupedAggregatingResultIterator, but with an abstract protected int
compare(Tuple t1, Tuple t2) method?
Actually I had exactly finished coding that part when I realized that the below
piece of code also needs to be overriden.
{code}
result.getKey(tempPtr);
return new SingleKeyValueTuple(KeyValueUtil.newKeyValue(tempPtr,
SINGLE_COLUMN_FAMILY, SINGLE_COLUMN, AGG_TIMESTAMP, value, 0, value.length));
{code}
So I was thinking to have abstract method "ImmutableBytesWritable
getAggregationKey(Tuple tuple)" instead. But still, my iterator wants to return
a MultiKeyValueTuple not a SingleKeyValueTuple, but I couldn't seem to come up
with a neat solution for abstraction of this last line of code.
> Support derived tables in FROM clause that needs extra steps of client-side
> aggregation or other processing
> -----------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-944
> URL: https://issues.apache.org/jira/browse/PHOENIX-944
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 3.0.0, 4.0.0, 5.0.0
> Reporter: Maryann Xue
> Assignee: Maryann Xue
> Fix For: 3.0.0, 4.0.0, 5.0.0
>
> Attachments: 944.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Groupby in both outer and inner queries cannot be flattened. We can apply an
> extra step of client-side aggregation to handle such cases.
> See DerivedTableIT.java for all those examples that are currently not
> supported.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
