[
https://issues.apache.org/jira/browse/PHOENIX-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181999#comment-14181999
]
James Taylor commented on PHOENIX-944:
--------------------------------------
Looks good, [~maryannxue]. One minor nit, perhaps it'd be a slight improvement
to have LookAheadResultIterator.wrap() return a PeekingResultIterator and then
change the if statement to do an instanceof PeekingResultIterator. Or maybe
move wrap from LookAheadResultIterator to PeekingResultIterator?
{code}
abstract public class LookAheadResultIterator implements PeekingResultIterator
{
public static LookAheadResultIterator wrap(final ResultIterator iterator) {
+ if (iterator instanceof LookAheadResultIterator) {
+ return (LookAheadResultIterator) iterator;
+ }
+
return new LookAheadResultIterator() {
{code}
> Support derived tables in FROM clause that needs extra steps of client-side
> aggregation or other processing
> -----------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-944
> URL: https://issues.apache.org/jira/browse/PHOENIX-944
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 3.0.0, 4.0.0, 5.0.0
> Reporter: Maryann Xue
> Assignee: Maryann Xue
> Fix For: 3.0.0, 4.0.0, 5.0.0
>
> Attachments: 944-3.patch, 944.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Groupby in both outer and inner queries cannot be flattened. We can apply an
> extra step of client-side aggregation to handle such cases.
> See DerivedTableIT.java for all those examples that are currently not
> supported.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
