[
https://issues.apache.org/jira/browse/PHOENIX-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240590#comment-14240590
]
James Taylor commented on PHOENIX-1514:
---------------------------------------
I went through your pull request - looks fantastic, [~ndimiduk].
Not so sure we want to change our SQL dialect to support a type system that we
want to deprecate, though. It'd be cool to swap in the new HBase type system,
though. We could have a config parameter that defines your type system. There'd
be some work required in the RowKeySchema and RowKeyValueAccessor (though this
one could go through RowKeySchema instead so that everything is isolated
there). The RowKeySchema class is more or less like your StructIterator (if I
remember your class names correctly).
> Break up PDataType Enum
> -----------------------
>
> Key: PHOENIX-1514
> URL: https://issues.apache.org/jira/browse/PHOENIX-1514
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 5.0.0
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Fix For: 5.0.0
>
> Attachments: PHOENIX-1514.00.patch
>
>
> A first step in adopting (a portion of) HBase's type encodings is to break up
> the PDataType enum into an interface. This will pave the way for more
> flexibility going forward.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
