[
https://issues.apache.org/jira/browse/PHOENIX-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241645#comment-14241645
]
Nick Dimiduk commented on PHOENIX-1514:
---------------------------------------
[~jamestaylor] Updated PR. Rather than address each comment one-by-one, I've
done it all at once.
- For consistency sake, I've renamed all types to be prefixed with 'P'. This
may be a bit confusing because there are other objects in the schema package
that are prefixed with 'P', but I don't think it's a huge issue.
- If you want to create a schema.types package, that's fine. I have no
preference either way. I'll do it in this commit if you prefer, just say the
word.
- I've added apache licenses to all the files I added but missed in the first
go-round. I've also added license headers for files reported by rat plugin:
{noformat}
phoenix-core/src/it/java/org/apache/phoenix/end2end/InListIT.java
phoenix-core/src/it/java/org/apache/phoenix/end2end/StatsCollectorIT.java
phoenix-core/src/it/java/org/apache/phoenix/trace/TracingTestUtil.java
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/SuffixFilter.java
phoenix-core/src/main/java/org/apache/phoenix/schema/LocalIndexDataColumnRef.java
{noformat}
> Break up PDataType Enum
> -----------------------
>
> Key: PHOENIX-1514
> URL: https://issues.apache.org/jira/browse/PHOENIX-1514
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 5.0.0
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Fix For: 5.0.0
>
> Attachments: PHOENIX-1514.00.patch
>
>
> A first step in adopting (a portion of) HBase's type encodings is to break up
> the PDataType enum into an interface. This will pave the way for more
> flexibility going forward.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
