[
https://issues.apache.org/jira/browse/PHOENIX-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247091#comment-14247091
]
Nick Dimiduk commented on PHOENIX-1514:
---------------------------------------
Thanks for checking back [~jamestaylor]. The latest patch here is ready for
review/commit. I've resolved all the verify failures I've encountered, though
verify has been hanging for me in the mini cluster. Was hoping to do some
investigation this weekend but I didn't get to it. I see PHOENIX-1524 bumped
the HBase version, and it seems there's also PHOENIX-1528 for adding a stuck
test timeout. I'm running with both of these patches this morning.
Re: above mentioned changes, I've rolled them out in v02. I thought we could be
better about type safety in the primitive arrays (i.e.,
PhoenixArray$PrimitiveDoubleArray), but it was causing surprising cast
exceptions during verify tests. The idea was, for these types, we could have
PhoenixArray#array be of type, say, Double[] instead of Object[]. This required
a touch of reflection anywhere arrays are created, in particular when literals
are parsed. Rather than track down all those places in this patch, I decided
not to pursue that improvement here.
> Break up PDataType Enum
> -----------------------
>
> Key: PHOENIX-1514
> URL: https://issues.apache.org/jira/browse/PHOENIX-1514
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 5.0.0
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Fix For: 5.0.0
>
> Attachments: PHOENIX-1514.00.patch, PHOENIX-1514.01.patch,
> PHOENIX-1514.02.patch
>
>
> A first step in adopting (a portion of) HBase's type encodings is to break up
> the PDataType enum into an interface. This will pave the way for more
> flexibility going forward.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
