[ 
https://issues.apache.org/jira/browse/PHOENIX-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251304#comment-14251304
 ] 

Rajeshbabu Chintaguntla commented on PHOENIX-1536:
--------------------------------------------------

Handling index region splitting in the coprocessors using high level APIs in 
split transaction
 1) stepsBeforePONR 
 2) stepsAfterPONR 
 3) rollback on failures
which will take care of fs changes, zk and assignment related things and so on. 
Other than that not touching any internal things.
Passing index region split related meta entries through coprocessors.

[~jamestaylor]
bq. the conditional logic to use the copy/paste IndexSplitTransaction for 
pre-0.98.9 users and the new one otherwise.
It's there. IndexSplitTransaction will be used for pre-0.98.9 otherwise 
SplitTransaction.
{code}
+                try {
+                    st = new SplitTransaction(indexRegion, splitKey);
+                    Field field = st.getClass().getField("useZKForAssignment");
+                    field.setBoolean(st,
+                        
environment.getConfiguration().getBoolean("hbase.assignment.usezk", true));
+                } catch (NoSuchFieldException e) {
+                    st = new IndexSplitTransaction(indexRegion, splitKey);
+                }
{code}

bq. he fixes for the path to IndexSplitTransaction for pre-0.98.9 users 
(assuming there are some duplicate fixes necessary here too).
If any fixes need to fix in IndexSplitTransaction as well. As of now it's fine. 

Thanks.

> Make use of SplitTransaction to split local index region from 0.98.9 onwards
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-1536
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1536
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.2.2
>            Reporter: Rajeshbabu Chintaguntla
>             Fix For: 5.0.0, 4.3
>
>         Attachments: PHOENIX-1536.patch
>
>
> Currently we are using IndexSpilitTransaction which is duplicate of 
> SplitTransaction with minor changes. From 0.98.9 onwards we can use the 
> SplitTransaction itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to