[ 
https://issues.apache.org/jira/browse/PHOENIX-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250510#comment-14250510
 ] 

Lars Hofhansl commented on PHOENIX-1536:
----------------------------------------

I might be the dissenter here... I find it somewhat elegant to simply use the 
SplitTransaction we already in HBase to split the index region.

It seems here we not looking for a hook or an interface but and transactional 
way to split a region. Since HBase has that code it is fine to use that.
>From that angle it is OK for Phoenix to have its own code, if that code is a 
>copy from HBase's code for simplicity that's fine too, no? If SplitTransaction 
>in HBase changes, it does not mean we need to change IndexSplitTransaction.

So I would leave it the way it is. Use IndexSplitTransaction, Phoenix's own 
code to safely split an index region. In HBase we will certainly not agree to 
not change SplitTransaction going forward.


> Make use of SplitTransaction to split local index region from 0.98.9 onwards
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-1536
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1536
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.2.2
>            Reporter: Rajeshbabu Chintaguntla
>             Fix For: 5.0.0, 4.3
>
>         Attachments: PHOENIX-1536.patch
>
>
> Currently we are using IndexSpilitTransaction which is duplicate of 
> SplitTransaction with minor changes. From 0.98.9 onwards we can use the 
> SplitTransaction itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to