[ 
https://issues.apache.org/jira/browse/PHOENIX-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251175#comment-14251175
 ] 

ramkrishna.s.vasudevan commented on PHOENIX-1536:
-------------------------------------------------

I think this patch is just going to be an incremental approach.  Now by 
extending SplitTransaction we are going to remove all the redundant code and 
the only change that we need is how the split key is going to be handled.  As 
HBASE-12583 is committed to 0.98.9 I think that change is also going to be 
simpler considering the fact that we can always have a split policy for the  
index region and just change the way the split key is read and used for finding 
out the keys that belong to the top and bottom half. 
And the logic in IndexSplitTransaction is just same as SplitTransaction in 
HBase so once we extend the SplitTransaction we are not going to play with the 
znodes or the FS layout also.
So which means using SplitTransaction itself for the index region would make 
things simpler considering the fact that Secondary index regions are also 
normal HBase regions.
And also all possible hooks were introduced inorder to support a transactional 
way of splitting of sibling regions using hooks like preSplitBeforePONR(), 
preSplitAfterPONR().
[~rajeshbabu]
Is there any change that we are doing here in IndexSplitTransaction that is 
messing with the znodes and FS layout other than the way the split key is 
accounted for?

> Make use of SplitTransaction to split local index region from 0.98.9 onwards
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-1536
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1536
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.2.2
>            Reporter: Rajeshbabu Chintaguntla
>             Fix For: 5.0.0, 4.3
>
>         Attachments: PHOENIX-1536.patch
>
>
> Currently we are using IndexSpilitTransaction which is duplicate of 
> SplitTransaction with minor changes. From 0.98.9 onwards we can use the 
> SplitTransaction itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to