[
https://issues.apache.org/jira/browse/PHOENIX-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261945#comment-14261945
]
ramkrishna.s.vasudevan commented on PHOENIX-1453:
-------------------------------------------------
addColumnsIfNotExists() in ConnectionQueryServicesImpl does not have a type
passed to it. This is the only place where am stuck now.
Also while filling up the arrays in combine() can we only fill the avg
(rowCount/szie, bytecount/size). What do you think?
bq. you can save an extra map lookup by doing the put into the map up front,
and then calling combine only if there was an old value there (like the old
code):
Actually in the new code we are collecting the GuidePostsRegionInfo. So I
thought once we cache the first GuidePostsInfo we could use the same
guidePostsInfo to call the combine(GuidePostsReginInfo).
> Collect row counts per region in stats table
> --------------------------------------------
>
> Key: PHOENIX-1453
> URL: https://issues.apache.org/jira/browse/PHOENIX-1453
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: ramkrishna.s.vasudevan
> Attachments: Phoenix-1453.patch, Phoenix-1453_1.patch,
> Phoenix-1453_10.patch, Phoenix-1453_2.patch, Phoenix-1453_3.patch,
> Phoenix-1453_7.patch, Phoenix-1453_8.patch
>
>
> We currently collect guideposts per equal chunk, but we should also capture
> row counts. Should we have a parallel array with the guideposts that count
> rows per guidepost, or is it enough to have a per region count?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
