[
https://issues.apache.org/jira/browse/PHOENIX-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240680#comment-14240680
]
James Taylor commented on PHOENIX-1453:
---------------------------------------
I don't think this needs to be a member variable in StatisticsCollection:
{code}
- + List<GuidePostsState> rowTracker =
+ new ArrayList<GuidePostsState>();
{code}
I think it can just be local to collectStatistics().
Also, why is rowCount kept in GuidePostsState instead of just in
GuidePostsInfo? If you add a new GuidePostInfo.incrementRowCount() method and
keep a list of the GuidePostInfo instances you need to increment and increment
them outside the loop, you should be good.
> Collect row counts per region in stats table
> --------------------------------------------
>
> Key: PHOENIX-1453
> URL: https://issues.apache.org/jira/browse/PHOENIX-1453
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: ramkrishna.s.vasudevan
> Attachments: Phoenix-1453.patch, Phoenix-1453_1.patch,
> Phoenix-1453_2.patch, Phoenix-1453_3.patch, Phoenix-1453_7.patch,
> Phoenix-1453_8.patch
>
>
> We currently collect guideposts per equal chunk, but we should also capture
> row counts. Should we have a parallel array with the guideposts that count
> rows per guidepost, or is it enough to have a per region count?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
