Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/34#issuecomment-70047865
Wow, @twdsilva. This is fantastic work! In terms of testing, we should test
this in the context of view index, salted tables, local indexes, immutable
indexes. Another dimension is the kind of expressions used in the functional
index. Let's figure out a good way to do this generally, so we get good test
coverage without too much copy/paste.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
