Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/34#discussion_r22997007
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -953,20 +973,39 @@ public MutationState createIndex(CreateIndexStatement
statement, byte[][] splits
PDataType dataType =
MetaDataUtil.getViewIndexIdDataType();
ColumnName colName =
ColumnName.caseSensitiveColumnName(MetaDataUtil.getViewIndexIdColumnName());
allPkColumns.add(new Pair<ColumnName,
SortOrder>(colName, SortOrder.getDefault()));
- columnDefs.add(FACTORY.columnDef(colName,
dataType.getSqlTypeName(), false, null, null, false, SortOrder.getDefault()));
+ columnDefs.add(FACTORY.columnDef(colName,
dataType.getSqlTypeName(), false, null, null, false, SortOrder.getDefault(),
null));
}
// First columns are the indexed ones
- for (Pair<ColumnName, SortOrder> pair : indexedPkColumns) {
- ColumnName colName = pair.getFirst();
- PColumn col = resolver.resolveColumn(null,
colName.getFamilyName(), colName.getColumnName()).getColumn();
- unusedPkColumns.remove(col);
- // Ignore view constants for updatable views as we
don't need these in the index
- if (col.getViewConstant() == null) {
- PDataType dataType =
IndexUtil.getIndexColumnDataType(col);
- colName =
ColumnName.caseSensitiveColumnName(IndexUtil.getIndexColumnName(col));
- allPkColumns.add(new Pair<ColumnName,
SortOrder>(colName, pair.getSecond()));
- columnDefs.add(FACTORY.columnDef(colName,
dataType.getSqlTypeName(), col.isNullable(), col.getMaxLength(),
col.getScale(), false, SortOrder.getDefault()));
- }
+ for (Pair<ParseNode, SortOrder> pair :
indexParseNodeAndSortOrderList) {
+ ParseNode parseNode = pair.getFirst();
+ ColumnName colName = null;
+ Integer maxLength = null;
+ Integer scale = null;
+ // if it is a column
+ if (parseNode instanceof ColumnParseNode) {
+ ColumnParseNode colParseNode =
(ColumnParseNode)parseNode;
+ PColumn col = resolver.resolveColumn(null,
colParseNode.getTableName(), colParseNode.getName()).getColumn();
+ unusedPkColumns.remove(col);
+ // Ignore view constants for updatable views as we
don't need these in the index
+ if (col.getViewConstant() != null)
+ continue;
+ colName =
ColumnName.caseSensitiveColumnName(IndexUtil.getIndexColumnName(col));
+ maxLength = col.getMaxLength();
+ scale = col.getScale();
+ }
+ // compile the parseNode to get an expression
+ PhoenixStatement phoenixStatment = new
PhoenixStatement(connection);
+ final StatementContext context = new
StatementContext(phoenixStatment, resolver);
+ ExpressionCompiler expressionCompiler = new
ExpressionCompiler(context);
+ Expression expression =
parseNode.accept(expressionCompiler);
--- End diff --
Another check you'll want is if expression.getDeterminism() != ALWAYS then
throw. That'll rule out NEXT VALUE FOR and CURRENT_DATE() which don't really
make sense (and can't be evaluated on the server side anyway).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
