Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/34#discussion_r22997186
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ---
@@ -883,6 +903,14 @@ public void readFields(DataInput input) throws
IOException {
dataEmptyKeyValueCF = Bytes.readByteArray(input);
emptyKeyValueCFPtr = new
ImmutableBytesPtr(Bytes.readByteArray(input));
+ int numIndexedExpressions = WritableUtils.readVInt(input);
+ indexedExpressions =
Sets.newLinkedHashSetWithExpectedSize(numIndexedExpressions);
+ for (int i = 0; i < numIndexedExpressions; i++) {
--- End diff --
How does this interop with having a mix of pure data columns in the ON
clause with functional expressions? The order is significant as far as I
remember, so I think you'll want to have both in the same list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
