[ 
https://issues.apache.org/jira/browse/PHOENIX-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301830#comment-14301830
 ] 

James Taylor commented on PHOENIX-1142:
---------------------------------------

Also, minor, but it looks like your Eclipse settings may not match our dev ones 
documented here: http://phoenix.apache.org/contributing.html#Code_conventions, 
in particular the import settings, based on this:
{code}
diff --git 
phoenix-core/src/main/java/org/apache/phoenix/expression/LiteralExpression.java 
phoenix-core/src/main/java/org/apache/phoenix/expression/LiteralExpression.java
index 757ba34..ababfeb 100644
--- 
phoenix-core/src/main/java/org/apache/phoenix/expression/LiteralExpression.java
+++ 
phoenix-core/src/main/java/org/apache/phoenix/expression/LiteralExpression.java
@@ -25,11 +25,7 @@ import java.sql.SQLException;
 import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
 import org.apache.hadoop.io.WritableUtils;
 import org.apache.phoenix.expression.visitor.ExpressionVisitor;
-import org.apache.phoenix.schema.types.PChar;
-import org.apache.phoenix.schema.types.PBoolean;
-import org.apache.phoenix.schema.types.PDataType;
-import org.apache.phoenix.schema.types.PVarchar;
-import org.apache.phoenix.schema.types.PhoenixArray;
+import org.apache.phoenix.schema.types.*;
{code}

How should the patch be applied too, as git apply isn't working for me against 
master?


> Improve CsvBulkLoadTool to parse different Date formats
> -------------------------------------------------------
>
>                 Key: PHOENIX-1142
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1142
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: David Kjerrumgaard
>            Assignee: Jeffrey Zhong
>         Attachments: PHOENIX-1142.patch
>
>
> Currently, the CsvBulkLoadTool uses a single 'default' format to parse dates 
> from the source CSV file. This can sometimes cause issues when the date 
> fields don't match this default format.
> Would it be possible to add a method for specifying / overriding the 
> 'default' date format?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to