Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307631
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/trace/PhoenixMetricsSink.java ---
@@ -175,7 +176,9 @@ private void createTable(Connection conn, String table)
throws SQLException {
TAG_COUNT + " smallint, " +
ANNOTATION_COUNT + " smallint" +
" CONSTRAINT pk PRIMARY KEY (" + TRACE.columnName
+ ", "
- + PARENT.columnName + ", " + SPAN.columnName +
"))\n";
+ + PARENT.columnName + ", " + SPAN.columnName +
"))\n" +
+ PhoenixDatabaseMetaData.TRANSACTIONAL + "=" +
Boolean.FALSE;
--- End diff --
Is the intent here to make tracing table transactional? What would happen
to the existing tracing table i.e. on a cluster with existing phoenix
deployment with tracing enabled? You will likely need some kind of upgrade path
to update the metadata of existing tracing table to mark it as transactional.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
