Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307861
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -101,7 +105,7 @@ else if (SchemaUtil.isPKColumn(column)) {
public int hashCode() {
final int prime = 31;
int result = alias == null ? 0 : alias.hashCode();
- result = prime * result +
this.table.getName().getString().hashCode();
+ result = prime * result + ( this.table!=null &&
this.table.getName()!=null ? this.table.getName().getString().hashCode() : 0);
--- End diff --
Can the table in a TableRef be null? If not, then you probably don't need
the null check. If it cannot be null, then it would be also good to add
Preconditions.checkNotNull() checks in various constructors of this class. If
it can be null, then you also need to modify the equals method too (commented
below).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
