[
https://issues.apache.org/jira/browse/PHOENIX-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478691#comment-15478691
]
James Taylor commented on PHOENIX-3181:
---------------------------------------
Here's some feedback on the patch:
- revert this change so that the PhoenixTestDriver is used as this will close
connections for you after a test suite finishes:
{code}
- public static final String PHOENIX_JDBC_URL = JDBC_PROTOCOL +
JDBC_PROTOCOL_SEPARATOR + LOCALHOST + JDBC_PROTOCOL_TERMINATOR +
PHOENIX_TEST_DRIVER_URL_PARAM;
+ //public static final String PHOENIX_JDBC_URL = JDBC_PROTOCOL +
JDBC_PROTOCOL_SEPARATOR + LOCALHOST + JDBC_PROTOCOL_TERMINATOR +
PHOENIX_TEST_DRIVER_URL_PARAM;
+ public static final String PHOENIX_JDBC_URL = JDBC_PROTOCOL +
JDBC_PROTOCOL_SEPARATOR + LOCALHOST ;
{code}
- In ConnectionQueryServicesTestImpl make the addConnection/removeConnection
methods synchronized and put this code in close() in a synchronize(this) block:
{code}
Set<PhoenixConnection> connections = this.connections;
this.connections = Sets.newHashSet();
{code}
- Why did you make a number of classes abstract? You can add an @Ignore tag
instead if you need to.
- Try increasing the OS level setting for max number of open files as mentioned
by [~samarthjain].
> Run test methods in parallel to reduce test suite run time
> ----------------------------------------------------------
>
> Key: PHOENIX-3181
> URL: https://issues.apache.org/jira/browse/PHOENIX-3181
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: prakul agarwal
> Attachments: PHOENIX-3181_4.x-HBase-1.1_WIP.patch,
> parallelize_4.x-Hbase1.1_wip.patch
>
>
> With PHOENIX-3036, the tests within a test class can be executed in parallel
> since the table names won't conflict. This should greatly reduce the time
> taken to run all of our tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
