[
https://issues.apache.org/jira/browse/PHOENIX-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487914#comment-15487914
]
James Taylor commented on PHOENIX-3263:
---------------------------------------
[~lomoree] - I don't completely understand this because Calcite doesn't provide
any parsing for DDL - Phoenix is doing this parsing. Take a look back at the
commit that [~maryannxue] did to support CREATE TABLE, in particular this
file[1]. We wouldn't want to have to parse using the existing Phoenix antlr
parser - in the end, we'll get rid of our parser completely.
[1]
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=blobdiff;f=phoenix-core/src/main/codegen/includes/parserImpls.ftl;h=e84e404cbaf0922426e894a4e6ef4220fef0afb7;hp=f7c203b2ec58ff9f39a5a25b5f78eba0ef6c20ef;hb=af237d5608c23ad418d24a24db3eb4aead5fc8f0;hpb=f344e3355ea1257144edde8306a1fe76675f5ab6
> Allow comma before CONSTRAINT to be optional
> --------------------------------------------
>
> Key: PHOENIX-3263
> URL: https://issues.apache.org/jira/browse/PHOENIX-3263
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
>
> In Phoenix, the comma before the CONSTRAINT is optional (which matches
> Oracle). Can this be supported in Calcite Phoenix?
> For example, this is ok in Phoenix:
> {code}
> CREATE TABLE T (
> K VARCHAR
> CONSTRAINT PK PRIMARY KEY (K));
> {code}
> as is this:
> {code}
> CREATE TABLE T (
> K VARCHAR,
> CONSTRAINT PK PRIMARY KEY (K));
> {code}
> If this is not feasible, we could require the comma and change the tests.
> This is leading to a lot of failures.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
