[
https://issues.apache.org/jira/browse/PHOENIX-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514535#comment-15514535
]
Hadoop QA commented on PHOENIX-3263:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12829925/PHOENIX-3263.patch
against master branch at commit b1682ddd541031437d2731c570a54fc6494c9801.
ATTACHMENT ID: 12829925
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/593//console
This message is automatically generated.
> Allow comma before CONSTRAINT to be optional
> --------------------------------------------
>
> Key: PHOENIX-3263
> URL: https://issues.apache.org/jira/browse/PHOENIX-3263
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: Eric Lomore
> Attachments: PHOENIX-3263.patch
>
>
> In Phoenix, the comma before the CONSTRAINT is optional (which matches
> Oracle). Can this be supported in Calcite Phoenix?
> For example, this is ok in Phoenix:
> {code}
> CREATE TABLE T (
> K VARCHAR
> CONSTRAINT PK PRIMARY KEY (K));
> {code}
> as is this:
> {code}
> CREATE TABLE T (
> K VARCHAR,
> CONSTRAINT PK PRIMARY KEY (K));
> {code}
> If this is not feasible, we could require the comma and change the tests.
> This is leading to a lot of failures.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
