[
https://issues.apache.org/jira/browse/PHOENIX-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15513709#comment-15513709
]
James Taylor commented on PHOENIX-3263:
---------------------------------------
[~lomoree] - would you mind attaching a patch file so we can get this fix
committed? To generate a patch file:
- commit your fix to your local repo with a commit message of the form
"PHOENIX-### <JIRA summary>", so for this one it'd be "PHOENIX-3263 Allow comma
before CONSTRAINT to be optional"
- create a patch file by doing {{git format-patch --stdout HEAD^ >
PHOENIX-####.patch}}, so for this one it'd be {{git format-patch --stdout HEAD^
> PHOENIX-3263.patch}}
- attach the patch file to this JIRA using the More->Attach Files
For more on this process, see https://phoenix.apache.org/contributing.html
> Allow comma before CONSTRAINT to be optional
> --------------------------------------------
>
> Key: PHOENIX-3263
> URL: https://issues.apache.org/jira/browse/PHOENIX-3263
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
>
> In Phoenix, the comma before the CONSTRAINT is optional (which matches
> Oracle). Can this be supported in Calcite Phoenix?
> For example, this is ok in Phoenix:
> {code}
> CREATE TABLE T (
> K VARCHAR
> CONSTRAINT PK PRIMARY KEY (K));
> {code}
> as is this:
> {code}
> CREATE TABLE T (
> K VARCHAR,
> CONSTRAINT PK PRIMARY KEY (K));
> {code}
> If this is not feasible, we could require the comma and change the tests.
> This is leading to a lot of failures.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
