James Taylor commented on PHOENIX-3174:

Thanks for the patch, [~samarthjain]. One minor nit and one question:
- No need to call optimize here in MetaDataEndPointImpl as there's no tables 
involved in that statement:
+                        plan = 
connection.getQueryServices().getOptimizer().optimize(ps, plan);
- I thought you figured you need the NO_UPGRADE_ATTRIB after all for the cause 
of auto upgrade being set to true?

> Make minor upgrade a manual step
> --------------------------------
>                 Key: PHOENIX-3174
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3174
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Samarth Jain
>             Fix For: 4.9.0
>         Attachments: PHOENIX-3174.patch, PHOENIX-3174_v2.patch, 
> PHOENIX-3174_v3_master.patch, PHOENIX-3174_v4_master.patch
> Instead of automatically performing minor release upgrades to system tables 
> in an automated manner (on first connection), we should make upgrade a 
> separate manual step. If a newer client attempts to connect to a newer server 
> without the upgrade step having occurred, we'd fail the connection.
> Though not as automated, this would give users more control and visibility 
> into when an upgrade over system tables occurs.

This message was sent by Atlassian JIRA

Reply via email to