James Taylor commented on PHOENIX-3174:

bq. Yes, I renamed and moved the attribute to UpgradeUtil#DO_NOT_UPGRADE
Ah, I see - I missed that. Any reason why you moved the setting of this from 
getConnectionOnServer to getConnection? Looks like QueryUtil.getConnection() is 
called from AbstractBulkLoadTool.loadData(). I think that call should probably 
trigger an upgrade or an error, no?

Also, I remember you mentioned that you'd need to change occurrences of 
DriverManager.getConnection() in MetaDataClient to use the PhoenixConnection 
copy constructor so we don't lose the state of an upgrade being in progress. Is 
that no longer necessary?

> Make minor upgrade a manual step
> --------------------------------
>                 Key: PHOENIX-3174
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3174
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Samarth Jain
>             Fix For: 4.9.0
>         Attachments: PHOENIX-3174.patch, PHOENIX-3174_v2.patch, 
> PHOENIX-3174_v3_master.patch, PHOENIX-3174_v4_master.patch
> Instead of automatically performing minor release upgrades to system tables 
> in an automated manner (on first connection), we should make upgrade a 
> separate manual step. If a newer client attempts to connect to a newer server 
> without the upgrade step having occurred, we'd fail the connection.
> Though not as automated, this would give users more control and visibility 
> into when an upgrade over system tables occurs.

This message was sent by Atlassian JIRA

Reply via email to