[
https://issues.apache.org/jira/browse/PHOENIX-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505227#comment-15505227
]
Hadoop QA commented on PHOENIX-3174:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12829304/PHOENIX-3174_v5_master.patch
against master branch at commit e8ffc9c53513309c249aca740620ecc5df48a26a.
ATTACHMENT ID: 12829304
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
38 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ + " (PK1 VARCHAR NOT NULL, PK2 VARCHAR, KV1
VARCHAR, KV2 VARCHAR CONSTRAINT PK PRIMARY KEY(PK1, PK2))");
+ final ConnectionQueryServices delegate =
conn.unwrap(PhoenixConnection.class).getQueryServices();
+ ConnectionQueryServices servicesWithUpgrade = new
DelegateConnectionQueryServices(delegate) {
+ + " (k1 VARCHAR NOT NULL, k2 VARCHAR,
CONSTRAINT PK PRIMARY KEY(K1,K2))");
+ "CREATE INDEX " + tableName + "_IDX ON " +
tableName + " (KV1) INCLUDE (KV2)" );
+ + " (PK1 VARCHAR NOT NULL, PK2 VARCHAR,
KV1 VARCHAR, KV2 VARCHAR CONSTRAINT PK PRIMARY KEY(PK1, PK2))");
+ final ConnectionQueryServices delegate =
conn.unwrap(PhoenixConnection.class).getQueryServices();
+ ConnectionQueryServices servicesWithUpgrade = new
DelegateConnectionQueryServices(delegate) {
+ try (ResultSet rs =
phxConn.createStatement().executeQuery("SELECT * FROM " + tableName)) {
+ final ConnectionQueryServices services =
conn.unwrap(PhoenixConnection.class).getQueryServices();
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.GlobalIndexOptimizationIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/588//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/588//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/588//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/588//console
This message is automatically generated.
> Make minor upgrade a manual step
> --------------------------------
>
> Key: PHOENIX-3174
> URL: https://issues.apache.org/jira/browse/PHOENIX-3174
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Samarth Jain
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3174.patch, PHOENIX-3174_v2.patch,
> PHOENIX-3174_v3_master.patch, PHOENIX-3174_v4_master.patch,
> PHOENIX-3174_v5_master.patch
>
>
> Instead of automatically performing minor release upgrades to system tables
> in an automated manner (on first connection), we should make upgrade a
> separate manual step. If a newer client attempts to connect to a newer server
> without the upgrade step having occurred, we'd fail the connection.
> Though not as automated, this would give users more control and visibility
> into when an upgrade over system tables occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
