[
https://issues.apache.org/jira/browse/PHOENIX-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522893#comment-15522893
]
Hadoop QA commented on PHOENIX-2890:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12830280/PHOENIX-2890.patch
against master branch at commit cb7234d3f09c49f21e9a58a990c0efb141ddf6c5.
ATTACHMENT ID: 12830280
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
36 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ serverProps.put(QueryServices.EXTRA_JDBC_ARGUMENTS_ATTRIB,
QueryServicesOptions.DEFAULT_EXTRA_JDBC_ARGUMENTS);
+ setUpTestDriver(new ReadOnlyProps(serverProps.entrySet().iterator()),
new ReadOnlyProps(clientProps.entrySet().iterator()));
+ final String indxTable = String.format("%s_%s", dataTableName,
FailingRegionObserver.INDEX_NAME);
+ props.setProperty(QueryServices.IS_NAMESPACE_MAPPING_ENABLED,
Boolean.toString(isNamespaceEnabled));
+ String.format("CREATE TABLE %s (ID BIGINT NOT NULL, NAME
VARCHAR, ZIP INTEGER CONSTRAINT PK PRIMARY KEY(ID ROW_TIMESTAMP)) %s",
+ stmt.execute(String.format("CREATE %s INDEX %s ON %s
(LPAD(UPPER(NAME),11,'x')||'_xyz') ",
+ .execute(String.format("ALTER INDEX %s on %s REBUILD
ASYNC", indxTable, fullTableName));
+ ResultSet rs = conn.getMetaData().getTables(null,
StringUtil.escapeLike(schemaName), indxTable,
+ .executeQuery(String.format("SELECT " +
PhoenixDatabaseMetaData.ASYNC_REBUILD_TIMESTAMP + " FROM "
+ PTable pindexTable = PhoenixRuntime.getTable(conn,
SchemaUtil.getTableName(schemaName, indxTable));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.OrderByIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/598//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/598//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/598//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/598//console
This message is automatically generated.
> Extend IndexTool to allow incremental index rebuilds
> ----------------------------------------------------
>
> Key: PHOENIX-2890
> URL: https://issues.apache.org/jira/browse/PHOENIX-2890
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Priority: Minor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-2890.patch, PHOENIX-2890_wip.patch
>
>
> Currently , IndexTool is used for initial index rebuild but I think we should
> extend it to be used for recovering index from last disabled timestamp too.
> In general terms if we run IndexTool on already existing/new index, then it
> should follow the same semantics as followed by background Index rebuilding
> thread.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
