ASF GitHub Bot commented on PHOENIX-2890:

Github user chrajeshbabu commented on a diff in the pull request:

    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java ---
    @@ -85,7 +102,7 @@
         private static final Option DATA_TABLE_OPTION = new Option("dt", 
"data-table", true,
                 "Data table name (mandatory)");
         private static final Option INDEX_TABLE_OPTION = new Option("it", 
"index-table", true,
    -            "Index table name(mandatory)");
    +            "Index table name(not required in case of partial 
    --- End diff --
    Better to have an argument for partial rebuilding than go by rebuild if we 
don't mention index table.

> Extend IndexTool to allow incremental index rebuilds
> ----------------------------------------------------
>                 Key: PHOENIX-2890
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2890
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Minor
>             Fix For: 4.9.0
>         Attachments: PHOENIX-2890.patch, PHOENIX-2890_wip.patch
> Currently , IndexTool is used for initial index rebuild but I think we should 
> extend it to be used for recovering index from last disabled timestamp too. 
> In general terms if we run IndexTool on already existing/new index, then it 
> should follow the same semantics as followed by background Index rebuilding 
> thread.

This message was sent by Atlassian JIRA

Reply via email to