[ 
https://issues.apache.org/jira/browse/PHOENIX-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584739#comment-15584739
 ] 

ASF GitHub Bot commented on PHOENIX-2890:
-----------------------------------------

Github user chrajeshbabu commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/210#discussion_r83795678
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java 
---
    @@ -568,4 +580,52 @@ public void testAsyncCreatedDate() throws Exception {
             assertTrue(d2.after(d1));
             assertFalse(rs.next());
         }
    +    
    +    @Test
    +    public void testAsyncRebuildTimestamp() throws Exception {
    +        long l0 = System.currentTimeMillis();
    +        Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
    +        Connection conn = DriverManager.getConnection(getUrl(), props);
    +        conn.setAutoCommit(false);
    +        String testTable = generateUniqueName();
    +
    +
    +        String ddl = "create table " + testTable  + " (k varchar primary 
key, v1 varchar, v2 varchar, v3 varchar)";
    +        PreparedStatement stmt = conn.prepareStatement(ddl);
    +        stmt.execute();
    +        String indexName = "R_ASYNCIND_" + generateUniqueName();
    +        
    +        ddl = "CREATE INDEX " + indexName + "1 ON " + testTable  + " (v1) 
";
    +        stmt = conn.prepareStatement(ddl);
    --- End diff --
    
    You can use createStatement than prepareStatement here.


> Extend IndexTool to allow incremental index rebuilds
> ----------------------------------------------------
>
>                 Key: PHOENIX-2890
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2890
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Minor
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-2890.patch, PHOENIX-2890_wip.patch
>
>
> Currently , IndexTool is used for initial index rebuild but I think we should 
> extend it to be used for recovering index from last disabled timestamp too. 
> In general terms if we run IndexTool on already existing/new index, then it 
> should follow the same semantics as followed by background Index rebuilding 
> thread.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to