[
https://issues.apache.org/jira/browse/PHOENIX-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537112#comment-15537112
]
ASF GitHub Bot commented on PHOENIX-2827:
-----------------------------------------
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/213#discussion_r81420342
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/ClientScanPlan.java ---
@@ -106,12 +106,18 @@ public ExplainPlan getExplainPlan() throws
SQLException {
}
@Override
- public QueryPlan limit(Integer limit) {
- if (limit == this.limit || (limit != null &&
limit.equals(this.limit)))
+ public QueryPlan limit(Integer limit, Integer offset) {
+ if (limit == this.limit || (limit != null &&
limit.equals(this.limit))) {
--- End diff --
I can see there's a big confusion here. Basically, offset and limit should
be treated the same way. So here, it should be "if both the old limit and the
old offset are same as as the new ones specified, we return this; otherwise we
create a new object."
> Support OFFSET in Calcite-Phoenix
> ---------------------------------
>
> Key: PHOENIX-2827
> URL: https://issues.apache.org/jira/browse/PHOENIX-2827
> Project: Phoenix
> Issue Type: Task
> Reporter: Maryann Xue
> Assignee: Eric Lomore
> Labels: calcite
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
