[ https://issues.apache.org/jira/browse/PHOENIX-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537111#comment-15537111 ]
ASF GitHub Bot commented on PHOENIX-2827: ----------------------------------------- Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/213#discussion_r81418723 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/rel/PhoenixLimit.java --- @@ -76,20 +76,27 @@ public RelOptCost computeSelfCost(RelOptPlanner planner, RelMetadataQuery mq) { @Override public double estimateRowCount(RelMetadataQuery mq) { - double rows = super.estimateRowCount(mq); + double rows = super.estimateRowCount(mq); + if(offset != null) { + return Math.max(0, Math.min(RexLiteral.intValue(fetch), rows - RexLiteral.intValue(offset))); + } return Math.min(RexLiteral.intValue(fetch), rows); --- End diff -- I'd write: int offset = this.offset == null ? 0 : RexLiteral.intValue(this.offset); return Math.min(RexLiteral.intValue(fetch), rows - offset); > Support OFFSET in Calcite-Phoenix > --------------------------------- > > Key: PHOENIX-2827 > URL: https://issues.apache.org/jira/browse/PHOENIX-2827 > Project: Phoenix > Issue Type: Task > Reporter: Maryann Xue > Assignee: Eric Lomore > Labels: calcite > -- This message was sent by Atlassian JIRA (v6.3.4#6332)