[
https://issues.apache.org/jira/browse/PHOENIX-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537344#comment-15537344
]
ASF GitHub Bot commented on PHOENIX-2827:
-----------------------------------------
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/213#discussion_r81431821
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/ClientScanPlan.java ---
@@ -106,12 +106,18 @@ public ExplainPlan getExplainPlan() throws
SQLException {
}
@Override
- public QueryPlan limit(Integer limit) {
- if (limit == this.limit || (limit != null &&
limit.equals(this.limit)))
+ public QueryPlan limit(Integer limit, Integer offset) {
+ if (limit == this.limit || (limit != null &&
limit.equals(this.limit))) {
--- End diff --
Ah, my mistake. I'll get working on a patch that also supports offset
without limit. This should incorporate all of the changes noted above. Thanks
for clarifying.
> Support OFFSET in Calcite-Phoenix
> ---------------------------------
>
> Key: PHOENIX-2827
> URL: https://issues.apache.org/jira/browse/PHOENIX-2827
> Project: Phoenix
> Issue Type: Task
> Reporter: Maryann Xue
> Assignee: Eric Lomore
> Labels: calcite
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
