Hadoop QA commented on PHOENIX-3374:

{color:red}-1 overall{color}.  Here are the results of testing the latest 
  against master branch at commit d1156eaadfc72d9bcfe6418fa98a170d27b18264.
  ATTACHMENT ID: 12832939

    {color:green}+1 @author{color}.  The patch does not contain any @author 

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
                        Also please list what manual steps were performed to 
verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 

This message is automatically generated.

> Wrong data row key is getting generated for local indexes for functions with 
> fixed non null columns
> ---------------------------------------------------------------------------------------------------
>                 Key: PHOENIX-3374
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3374
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 4.9.0, 4.8.2
>         Attachments: PHOENIX-3374.patch
> When we create local indexes on functions then while joining back missing 
> columns from data table is generating wrong data row key. 
> When we generated index row key schema we are initializing isNullableToBe to 
> true always even if the expression might be not null. Because of this we 
> might change the column type to other castable one and may consider actual 
> data as separator bytes.
> {noformat}
> ...
>             if (indexField == null) {
>                 Expression e = expressionItr.next();
>                 isNullableToBe = true;
>                 dataTypeToBe = 
> IndexUtil.getIndexColumnDataType(isNullableToBe, e.getDataType());
>                 sortOrderToBe = descIndexColumnBitSet.get(i) ? SortOrder.DESC 
> : SortOrder.ASC;
>                 maxLengthToBe = e.getMaxLength();
>                 scaleToBe = e.getScale();
> ...
> {noformat}

This message was sent by Atlassian JIRA

Reply via email to