[
https://issues.apache.org/jira/browse/PHOENIX-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614652#comment-15614652
]
Hadoop QA commented on PHOENIX-3374:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12835759/PHOENIX-3374_v2.patch
against master branch at commit 44c5a032818bac2809ef664321542ec77f5df1f9.
ATTACHMENT ID: 12835759
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
43 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ "CREATE TABLE IF NOT EXISTS test_table (user_time
UNSIGNED_TIMESTAMP NOT NULL,user_id varchar NOT NULL,col1 varchar,col2
double,CONSTRAINT pk PRIMARY KEY(user_time,user_id)) SALT_BUCKETS = 20";
+ "select substr(to_char(user_time), 0, 10) as
ddate, hour(user_time) as hhour, user_id, col1,col2 from test_table where
hour(user_time)=14 group by user_id, col1, col2, ddate, hhour limit 1");
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.schema.MutationTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/651//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/651//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/651//console
This message is automatically generated.
> Wrong data row key is getting generated for local indexes for functions with
> fixed non null columns
> ---------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3374
> URL: https://issues.apache.org/jira/browse/PHOENIX-3374
> Project: Phoenix
> Issue Type: Bug
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.9.0, 4.8.2
>
> Attachments: PHOENIX-3374.patch, PHOENIX-3374_v2.patch,
> PHOENIX-3374_v3.patch
>
>
> When we create local indexes on functions then while joining back missing
> columns from data table is generating wrong data row key.
> When we generated index row key schema we are initializing isNullableToBe to
> true always even if the expression might be not null. Because of this we
> might change the column type to other castable one and may consider actual
> data as separator bytes.
> {noformat}
> ...
> if (indexField == null) {
> Expression e = expressionItr.next();
> isNullableToBe = true;
> dataTypeToBe =
> IndexUtil.getIndexColumnDataType(isNullableToBe, e.getDataType());
> sortOrderToBe = descIndexColumnBitSet.get(i) ? SortOrder.DESC
> : SortOrder.ASC;
> maxLengthToBe = e.getMaxLength();
> scaleToBe = e.getScale();
> ...
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
