[ 
https://issues.apache.org/jira/browse/PHOENIX-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615296#comment-15615296
 ] 

Rajeshbabu Chintaguntla commented on PHOENIX-3374:
--------------------------------------------------

The test is flaky and not related to the patch.  Here is the my local test 
result.
{noformat}
[INFO] Apache Phoenix ..................................... SUCCESS [  1.496 s]
[INFO] Phoenix Core ....................................... SUCCESS [27:11 min]
[INFO] Phoenix - Flume .................................... SUCCESS [01:13 min]
[INFO] Phoenix - Pig ...................................... SUCCESS [08:59 min]
[INFO] Phoenix Query Server Client ........................ SUCCESS [ 12.818 s]
[INFO] Phoenix Query Server ............................... SUCCESS [01:43 min]
[INFO] Phoenix - Pherf .................................... SUCCESS [01:41 min]
[INFO] Phoenix - Spark .................................... SUCCESS [02:10 min]
[INFO] Phoenix - Hive ..................................... SUCCESS [02:47 min]
[INFO] Phoenix Client ..................................... SUCCESS [ 49.049 s]
[INFO] Phoenix Server ..................................... SUCCESS [  2.947 s]
[INFO] Phoenix Assembly ................................... SUCCESS [ 25.028 s]
[INFO] Phoenix - Tracing Web Application .................. SUCCESS [  6.853 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 47:26 min
[INFO] Finished at: 2016-10-28T15:14:33+05:30
[INFO] Final Memory: 147M/1662M
[INFO] ------------------------------------------------------------------------
{noformat}

> Wrong data row key is getting generated for local indexes for functions with 
> fixed non null columns
> ---------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3374
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3374
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 4.9.0, 4.8.2
>
>         Attachments: PHOENIX-3374.patch, PHOENIX-3374_v2.patch, 
> PHOENIX-3374_v3.patch
>
>
> When we create local indexes on functions then while joining back missing 
> columns from data table is generating wrong data row key. 
> When we generated index row key schema we are initializing isNullableToBe to 
> true always even if the expression might be not null. Because of this we 
> might change the column type to other castable one and may consider actual 
> data as separator bytes.
> {noformat}
> ...
>             if (indexField == null) {
>                 Expression e = expressionItr.next();
>                 isNullableToBe = true;
>                 dataTypeToBe = 
> IndexUtil.getIndexColumnDataType(isNullableToBe, e.getDataType());
>                 sortOrderToBe = descIndexColumnBitSet.get(i) ? SortOrder.DESC 
> : SortOrder.ASC;
>                 maxLengthToBe = e.getMaxLength();
>                 scaleToBe = e.getScale();
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to