[ 
https://issues.apache.org/jira/browse/PHOENIX-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876887#comment-15876887
 ] 

Andrew Purtell commented on PHOENIX-3248:
-----------------------------------------

bq. I noticed that the ScanMetrics class is marked as 
@InterfaceAudience.Private. It would be valuable to surface these scan metrics 
within the phoenix metrics framework 

In 0.98? 

I looked at branch-1, branch-1.1, branch-1.2, and branch-1.3 and in each of 
these branches ScanMetrics is Public/Evolving. 
{code}
@InterfaceAudience.Public
@InterfaceStability.Evolving
public class ScanMetrics extends ServerSideScanMetrics {
{code}


bq. I see that 0.98 doesn't have a getScanMetrics() method in the Scan class. 
The later versions of hbase do though.

Suggest supporting this only in the Phoenix versions for >= 1.0


> Enable HBase server-side scan metrics to be returned to client and surfaced 
> through metrics
> -------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3248
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3248
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Samarth Jain
>
> We collect many client-side metrics[1] for Phoenix statements. We should 
> enable returning the more detailed server-side HBase scan metrics (through 
> Scan.setScanMetricsEnabled(true) and Scan.getScanMetrics()), and then 
> incorporate these into our client-side metrics.
> [1] https://phoenix.apache.org/metrics.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to