[ 
https://issues.apache.org/jira/browse/PHOENIX-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032099#comment-16032099
 ] 

Hadoop QA commented on PHOENIX-3248:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12870643/PHOENIX-3248-addendum.patch
  against master branch at commit c6080ea55539d83c5d95b26ac19d0b3823631cb3.
  ATTACHMENT ID: 12870643

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
45 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexExtendedIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PointInTimeQueryIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/945//testReport/
Javadoc warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/945//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/945//console

This message is automatically generated.

> Enable HBase server-side scan metrics to be returned to client and surfaced 
> through metrics
> -------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3248
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3248
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Karan Mehta
>             Fix For: 4.11.0
>
>         Attachments: PHOENIX-3248.002.patch, PHOENIX-3248-addendum.patch, 
> PHOENIX-3248.patch
>
>
> We collect many client-side metrics[1] for Phoenix statements. We should 
> enable returning the more detailed server-side HBase scan metrics (through 
> Scan.setScanMetricsEnabled(true) and Scan.getScanMetrics()), and then 
> incorporate these into our client-side metrics.
> [1] https://phoenix.apache.org/metrics.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to